-

Sat, 29 May 2021 12:16:33 +0200

adminsforum@hubzilla.org

Anmol Sharma schrieb den folgenden Beitrag Sat, 29 May 2021 12:16:32 +0200

@!Hubzilla Support Forum (Hubzilla Support Forum)
The Ldap is failing on fresh install.
Log:

thrown in /var/www/hubzilla/extend/addon/hzaddons/ldapauth/ldapauth.php on line 67
[29-May-2021 02:54:18 America/Los_Angeles] PHP Fatal error:  Uncaught Error: Call to undefined function create_account() in /var/www/hubzilla/extend/addon/hzaddons/ldapauth/ldapauth.php:67
Stack trace:
#0 /var/www/hubzilla/include/plugin.php(499): ldapauth_hook_authenticate(0, Array)
#1 /var/www/hubzilla/include/auth.php(69): call_hooks('authenticate', Array)
#2 /var/www/hubzilla/include/auth.php(292): account_verify_password('test', 'mercredi')
#3 /var/www/hubzilla/Zotlabs/Web/WebServer.php(84): require('/var/www/hubzil...')
#4 /var/www/hubzilla/index.php(14): Zotlabs\Web\WebServer->run()
#5 {main}
  thrown in /var/www/hubzilla/extend/addon/hzaddons/ldapauth/ldapauth.php on line 67

show all 52 comments

Artaru Sat, 29 May 2021 12:54:34 +0200

Stefan Haydn

sh@hub.hayfidelity.de

I have the same issue. Fresh yunohost, fresh Hubzilla install.

Sat, 29 May 2021 13:15:43 +0200

Mario Vavti

mario@hub.somaton.com

Please open a ticket at framagit. This is probably a regression with the latest registration changes.

Coruscant Sat, 29 May 2021 15:17:11 +0200

Stefan Haydn

sh@hub.hayfidelity.de

Hey, @Anmol Sharma, do you have an account there? Could you please open a ticket?

Sat, 29 May 2021 16:08:45 +0200

Hilmar R (u-zapalot)

hi-u@zapalot.in-eu.net

@Mario Vavti
(5.6)
In include/account.php the function create_account($arr) is named create_account_from_register($arr), and the old fun is marked(named) as obsolete. At #396 there is also to find a (commented out) hook call.

Sat, 29 May 2021 16:42:44 +0200

Hilmar R (u-zapalot)

hi-u@zapalot.in-eu.net

@Anmol Sharma
@Stefan Haydn

https://framagit.org/hubzilla/core/-/issues/1575

Polis Massa Sat, 29 May 2021 17:04:26 +0200

Stefan Haydn

sh@hub.hayfidelity.de

Thank you, @Hilmar R.

Mon, 31 May 2021 13:30:54 +0200 zuletzt bearbeitet: Mon, 31 May 2021 21:47:36 +0200

Mario Vavti

mario@hub.somaton.com

@Anmol Sharma since i do not have ldap set up i will need your help... I have created a patch which should fix the regression:

diff --git a/ldapauth/ldapauth.php b/ldapauth/ldapauth.php
index 09b709ef024e3260f747ccdfee2ddaa58a4dc009..498a03f1373870b4b7f8466168cb489cb30308b6 100644
--- a/ldapauth/ldapauth.php
+++ b/ldapauth/ldapauth.php
@@ -6,9 +6,9 @@
  * Author: Mike Macgirvin
  * Maintainer: Mike Macgirvin
  */
- 
+
 /**
- * 
+ *
  * Module: LDAP Authenticate
  *
  * Authenticate a user against an LDAP directory
@@ -18,8 +18,8 @@
  * Optionally authenticates only if a member of a given group in the directory.
  *
  * Note when using with Windows Active Directory: you may need to set TLS_CACERT in your site
- * ldap.conf file to the signing cert for your LDAP server. 
- * 
+ * ldap.conf file to the signing cert for your LDAP server.
+ *
  * The required configuration options for this module may be set in the .htconfig.php file
  * e.g.:
  *
@@ -64,8 +64,39 @@ function ldapauth_hook_authenticate($a,&$b) {
         );
         if((! $results) && ($mail) && intval(get_config('ldapauth','create_account')) == 1) {
             require_once('include/account.php');
-            $acct = create_account(array('email' => $mail, 'password' => random_string()));            
+            $now = datetime_convert();
+            $salt = random_string(32);
+            $pass = random_string(64);
+            $password = $salt . ',' . hash('whirlpool', $salt . $pass);
+
+            q("INSERT INTO register ("
+                . "reg_didx, reg_did2, reg_hash, reg_created, reg_startup, reg_expires,"
+                . "reg_email, reg_pass, reg_lang, reg_atip, reg_stuff)"
+                . " VALUES ('%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s') ",
+                dbesc('e'),
+                dbesc($mail),
+                dbesc('ldapauth'),
+                dbesc($now),
+                dbesc($now),
+                dbesc(datetime_convert('UTC', 'UTC', $now . ' + 1 hour')),
+                dbesc($mail),
+                dbesc($password),
+                dbesc(App::$language),
+                dbesc($_SERVER['REMOTE_ADDR']),
+                dbesc(json_encode([]))
+            );
+
+            $reg = q("SELECT reg_id FROM register WHERE reg_did2 = '%s' AND reg_pass = '%s'",
+                dbesc($mail),
+                dbesc($password)
+            );
+
+            $acct = create_account_from_register(['reg_id' => $reg[0]['reg_id']]);
             if($acct['success']) {
+                q("UPDATE register SET reg_vital = 0 WHERE reg_id = %d",
+                    intval($reg[0]['reg_id'])
+                );
+
                 logger('ldapauth: Created account for ' . $b['username'] . ' using ' . $mail);
                 info(t('An account has been created for you.'));
                 $b['user_record'] = $acct['account'];
@@ -79,9 +110,9 @@ function ldapauth_hook_authenticate($a,&$b) {
         }
         if((! $results) && $b['user_record'] && $nickname && $displayname && intval(get_config('ldapauth','create_channel'))) {
             $c = create_identity( [
-                'name' => $displayname, 
-                'nickname' => $nickname, 
-                'account_id' => $b['user_record']['account_id'], 
+                'name' => $displayname,
+                'nickname' => $nickname,
+                'account_id' => $b['user_record']['account_id'],
                 'permissions_role' => $perms_role
             ] );

It would be great if you could try this patch and report back if this fixes the issue...

Mon, 31 May 2021 17:34:07 +0200

Hilmar R (u-zapalot)

hi-u@zapalot.in-eu.net

@Mario Vavti
IMO that could work, but I also have no LDAP environment.

Tue, 01 Jun 2021 07:52:00 +0200

Mario Vavti

mario@hub.somaton.com

@Anmol Sharma you have to manually apply the patch...

Tue, 01 Jun 2021 07:58:28 +0200

Mario Vavti

mario@hub.somaton.com

Save the code i posted above into a file e.g. ldapauth.patch.
Move the file to the addons directory e.g. extend/addon/hzaddons.
Then run patch -p 1 < ldapauth.patch from the terminal.

Tue, 01 Jun 2021 08:02:12 +0200 zuletzt bearbeitet: Tue, 01 Jun 2021 08:30:04 +0200

Mario Vavti

mario@hub.somaton.com

Yes, it is the same but it does not look like it got applied. Also the original commit contains two typos which were fixed in a later commit. I fixed those in the code above too...

Tue, 01 Jun 2021 08:20:27 +0200

Mario Vavti

mario@hub.somaton.com

Hm... Are you at a clean master branch?

Tue, 01 Jun 2021 08:28:31 +0200

Mario Vavti

mario@hub.somaton.com

What does git diff say?

Tue, 01 Jun 2021 08:44:55 +0200

Mario Vavti

mario@hub.somaton.com

Well... I am afraid then you will have to fix the failed hunks manually...

Tue, 01 Jun 2021 18:36:36 +0200

Hilmar R (u-zapalot)

hi-u@zapalot.in-eu.net

@Anmol Sharma
The errors show the same as before.

If you are able to ssh into your a d d o n /ldapauth/ dir and do a wget https://framagit.org/hubzilla/addons/-/raw/dcc/ldapauth/ldapauth.php?inline=false is one way to have to code,

else take the url to download and upload the file to the addon ldapauth dir.

Have an eye how your addon dir is named.

Kashyyk Tue, 01 Jun 2021 19:16:01 +0200

Stefan Haydn

sh@hub.hayfidelity.de

@Hilmar R I have tried it this way (the way @Mario Vavti suggested above lead to the same error as Anmol has posted) and now if I want to login, it only reloads the login page.

Tue, 01 Jun 2021 19:20:08 +0200

Mario Vavti

mario@hub.somaton.com

@Stefan Haydn any errors in the php log?

Tue, 01 Jun 2021 19:23:12 +0200

Mario Vavti

mario@hub.somaton.com

@Stefan Haydn nevermind, if the patch did not succeed completely it is expected to throw an error i guess...

Mustafar Tue, 01 Jun 2021 19:36:35 +0200

Stefan Haydn

sh@hub.hayfidelity.de

@Mario Vavti In the php.log there is the same error as Anmol stated above.

Tue, 01 Jun 2021 19:43:29 +0200

Mario Vavti

mario@hub.somaton.com

@Stefan Haydn can you apply the patch orchange the code manualy? See here: https://framagit.org/hubzilla/addons/-/raw/dcc/ldapauth/ldapauth.php

Ord Mantell Tue, 01 Jun 2021 19:49:42 +0200

Stefan Haydn

sh@hub.hayfidelity.de

@Mario Vavti Still the same: Just reloading the login page.

To be clear: I have deleted everything inside ldapauth.php and copied the code from your link above into the empty file. Right?

Tue, 01 Jun 2021 21:19:08 +0200

Mario Vavti

mario@hub.somaton.com

@Stefan Haydn anything else in the php log at this point?

Saleucami Tue, 01 Jun 2021 22:09:41 +0200

Stefan Haydn

sh@hub.hayfidelity.de

@Mario Vavti No, nothing else.

Tue, 01 Jun 2021 22:12:16 +0200

Hilmar R (u-zapalot)

hi-u@zapalot.in-eu.net

@Stefan Haydn

...it only reloads the login page...

Can you repeat the case and when seeing the login page again, please verify if really not logged in (app menu mychannel or the like). I had such conditions in the past where the login page was visible while even logged in. (Only to exclude that case).

Wed, 02 Jun 2021 10:10:13 +0200

Mario Vavti

mario@hub.somaton.com

@Stefan Haydn please also have a look in the Hubzilla logs...

Tund Wed, 02 Jun 2021 18:46:53 +0200

Stefan Haydn

sh@hub.hayfidelity.de

@Hilmar R It is only the reloaded login page.

@Mario Vavti: If the logs should reside in /var/log, there are no files from Hubzilla, as it seems.

Wed, 02 Jun 2021 19:11:33 +0200

Grouchy

grouchy@hub.grouchysysadmin.com

@Stefan Haydn

The Hubzilla log will be located as defined under Admin -> Logs. It's pretty unlikely to be in /var/log/

Boz Pity Wed, 02 Jun 2021 19:24:14 +0200

Stefan Haydn

sh@hub.hayfidelity.de

@Grouchy I should have mentioned it is about a yunohost install. I can't login in my yunohost hubzilla (this will get my nomadic alternative), so Admin --> Logs isn't reachable for me there.

Could I see the hubzilla logs somewhere in yunohost, @Anmol Sharma?

Thu, 03 Jun 2021 12:28:51 +0200

Hilmar R (u-zapalot)

hi-u@zapalot.in-eu.net

... ldapauth.php configuration file...

that is not a configuration file. Instead, the configuration is in the hidden .htconfig.php file or in the database, when set via util/config.

* The required configuration options for this module may be set in the .htconfig.php file
 * e.g.:
 *
 * App::$config['ldapauth']['ldap_server'] = 'host.example.com';
 *
 * Parameters:
 * ldap_server = DNS hostname of LDAP service, or URL e.g. ldaps://example.com
 * ldap_binddn = LDAP DN of an account to bind with to search LDAP
 * ldap_bindpw = password for LDAP bind DN
 * ldap_searchdn = base DN for the search root of the LDAP directory
 * ldap_userattr = the name of the attribute containing the username, e.g. SAMAccountName
 * ldap_group = (optional) DN of group to check membership
 * create_account = (optional) 1 or 0 (default), automatically create Hubzilla accounts based on the LDAP 'mail' attribute
 *

The parameters depend on your environment. Take the values from the Ldap server or ask someone who manages the Ldap server.

The ldapauth.php file contains the code of the addon and should have that @Mario Vavti told.

Thu, 03 Jun 2021 14:56:02 +0200

Hilmar R (u-zapalot)

hi-u@zapalot.in-eu.net

@Anmol Sharma
Thanks for the reply and the infos. Will inspect what Mike had done for zap.

Thu, 03 Jun 2021 19:44:41 +0200

Mario Vavti

mario@hub.somaton.com

@Anmol Sharma i was thinking about the Hubzilla logs available from /admin/logs

Thu, 03 Jun 2021 19:56:53 +0200

Mario Vavti

mario@hub.somaton.com

Just pushed another commit that might or might not help: https://framagit.org/hubzilla/addons/-/raw/e9ed8048c02c0e3b93fbb989c6ce6287da007ab0/ldapauth/ldapauth.php

Geonosis Thu, 03 Jun 2021 20:46:06 +0200

Stefan Haydn

sh@hub.hayfidelity.de

@Mario Vavti Still reloading just the login page. Have checked for reference with the original one, still a blank page.

Artaru Thu, 03 Jun 2021 20:49:41 +0200

Stefan Haydn

sh@hub.hayfidelity.de

@Mario Vavti If I try without a ldapauth.php, it still reloads only the login page.

Thu, 03 Jun 2021 21:24:28 +0200

Mario Vavti

mario@hub.somaton.com

@Stefan Haydn do you login with email or channel name?

Tatooine Thu, 03 Jun 2021 21:32:40 +0200

Stefan Haydn

sh@hub.hayfidelity.de

@Mario Vavti I have tried with both. Even when using a complete useless login, it only reloads the page.

Thu, 03 Jun 2021 21:45:03 +0200

Mario Vavti

mario@hub.somaton.com

@Stefan Haydn well, that is basically what happens if you enter a wrong password...

Thu, 03 Jun 2021 21:46:38 +0200

Mario Vavti

mario@hub.somaton.com

It would reallly help to have the hubzilla logs to see where it goes wrong...

Iego Thu, 03 Jun 2021 21:49:40 +0200

Stefan Haydn

sh@hub.hayfidelity.de

@Mario Vavti Yunohost suggests I should use the user I have installed Hubzilla with to gain admin rights, is that right, @Anmol Sharma?

Ord Mantell Thu, 03 Jun 2021 22:05:02 +0200

Stefan Haydn

sh@hub.hayfidelity.de

@Mario Vavti Could I see these logs somewhere via terminal?

Thu, 03 Jun 2021 22:36:56 +0200

Mario Vavti

mario@hub.somaton.com

@Stefan Haydn i don't know how this is configured in yunohost.

Basically you can enable the log in /admin/logs but you probably would need to create the logfile manually first...

Kessel Thu, 03 Jun 2021 22:37:42 +0200

Stefan Haydn

sh@hub.hayfidelity.de

From the yunohost page for Hubzilla:
"For admin rights: When installation is complete, you will need to visit your new hub's page and login with the admin account username which was entered at the time of installation process. You should then be able to create your first channel and have the admin rights for the hub."

Thu, 03 Jun 2021 22:53:39 +0200

Mario Vavti

mario@hub.somaton.com

@Stefan Haydn right. You have not been admin of your hub so far?

Alderaan Thu, 03 Jun 2021 22:54:15 +0200

Stefan Haydn

sh@hub.hayfidelity.de

@Mario Vavti But I can't reach admin/logs without having a login first, is this right?

Thu, 03 Jun 2021 22:57:41 +0200

Mario Vavti

mario@hub.somaton.com

@Stefan Haydn right. You have to log in as admin.

Ord Mantell Thu, 03 Jun 2021 23:01:11 +0200

Stefan Haydn

sh@hub.hayfidelity.de

@Mario Vavti No, I am not able to connect, as the login page doesn't let me in.

Fri, 04 Jun 2021 07:26:40 +0200

Mario Vavti

mario@hub.somaton.com

@Anmol Sharma

As I mentioned before the default ldapauth lines gave error logs in php.log, but the new lines in the post do not give anything in the logs.

Ok, but can you log in via ldap with the new code an does channel creation work as expected?

Kamino Fri, 04 Jun 2021 16:29:05 +0200 zuletzt bearbeitet: Fri, 04 Jun 2021 16:48:36 +0200

Stefan Haydn

sh@hub.hayfidelity.de

@Mario Vavti @Anmol Sharma Ok, I was crazy and hacked my way into the new Hub on my yunohost. A new registration was successful, but something still is broken, because of getting no pictures to upload and the maildress was like "d234232". Now the initial user is admin (had to set admin permissions in the database), has the correct mailaddress set, yet it's not possible to upload pictures. Nothing happens there, and also the initial user picture does not show up.

Funny side: All my attempts to log in with the initial user were in "waiting to approve/decline" state.

EDIT: I also am not able to post something.

Fri, 04 Jun 2021 17:44:58 +0200

Mario Vavti

mario@hub.somaton.com

@Stefan Haydn if require email is disabled in the registration settings, you will get a random ID instead. Hence d234232.

Fri, 04 Jun 2021 17:47:26 +0200

Mario Vavti

mario@hub.somaton.com

@Stefan Haydn Just a shot in the dark... Upload issue could be filesystem permissions...

Bespin Fri, 04 Jun 2021 18:31:21 +0200

Stefan Haydn

sh@hub.hayfidelity.de

@Anmol Sharma Yes, have tried it with the new code, but it reloaded only the login page. With „hacking“ into the hub I was able to see that all my attempts to login created the user but waited for approve/decline.

Sat, 03 Jul 2021 19:52:21 +0200

Stefan Haydn

sh@hub.hayfidelity.de

Hey, I have installed an instance again for testing purpose. Is there something I could help with?